Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Olink unique gcs filepaths #157

Merged
merged 2 commits into from Sep 4, 2019
Merged

Olink unique gcs filepaths #157

merged 2 commits into from Sep 4, 2019

Conversation

curlup
Copy link
Member

@curlup curlup commented Sep 3, 2019 •
edited

Using chip_barcode as olink_assay_run unique id.

This PR should probably be reviewed after #155 gets merged, because it's based on its branch.

@curlup curlup changed the base branch from master to fix_uuids_in_gs_urls September 3, 2019 21:53
@curlup curlup changed the base branch from fix_uuids_in_gs_urls to master September 3, 2019 21:53
@curlup curlup requested a review from jim-bo September 3, 2019 21:54
@curlup curlup changed the base branch from master to fix_uuids_in_gs_urls September 4, 2019 13:44
jim-bo
jim-bo approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@jim-bo jim-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@curlup curlup changed the base branch from fix_uuids_in_gs_urls to master September 4, 2019 17:05
@curlup curlup merged commit 6b3734c into master Sep 4, 2019
@curlup curlup deleted the olink_unique_gcs_filepaths branch September 4, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-bo jim-bo jim-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@curlup @jim-bo